[RESOLVED] PHP variables in SELECT options - HTML Forums

minus273 · 10-13-2009, 11:56 AM

Hi there,

I am building a form that contains select options; all is well and when the form is submitted the values come across correctly to the recipient.

However, when the form picks up an error like an invalid email address (and reloads itself) these values are reset.

The normal (static) input values are still populated, but the select boxes reset to 'none'.

How can I ensure that these values remain as the user has selected and they don't have to fill the whole form out again?

All variables are declared correctly before the form is encountered.

Here is my normal input line:

PHP Code:


			
<input type="text" size="17" tabindex="1" id="name" name="name" value="<?=$name;?>" />

And here is my select box:

PHP Code:


			
select id="select1" name="select1" class="dropper" value="<?=$select1;?>">

<option id="none" name="none" value="none">None</option>

<option id="main" name="main" value="option1">Option1</option>

<option id="main" name="main" value="option2">Option2</option>

<option id="main" name="main" value="option3">Option3</option>

</select>

Many thanks in advance, am I missing something REALLY obvious?

Vege · 10-13-2009, 12:07 PM

Quote:

<option selected="selected" value=option1">Option1</option>

select tag don't have value itself.

minus273 · 10-13-2009, 12:30 PM

Vege, thanks for your reply.

True, but removing it still does not help at all.

Vege · 10-13-2009, 01:08 PM

you also need to add the selected="selected" on the correct option

Pegasus · 10-13-2009, 01:21 PM

Silly question, but aren't id's and names supposed to be unique per page? I'm seeing 3 "main" ids.

minus273 · 10-13-2009, 01:33 PM

Yes you are correct Pegasus, they are actually different, I just substituted them for this forum.

This is driving me insane.

uze · 10-14-2009, 05:58 PM

The following code may be 'OTT' but it's future proof IMO:

Code:

<?php

// Set Choice variable
$choice = isset($_REQUEST['choice']) ? $_REQUEST['choice'] : 'none';

// Check value of param against $thisValue
function checkSelected($thisValue) {
	if($choice == $thisValue) {
		return 'selected="selected"';	
	}
}

// Our drop down options
$options = array(
	'none' => 'None',
	'option1' => 'option1',
	'option2' => 'option2',
	'option3' => 'option3'
);

// Loop through each option assigning the html to $return
foreach($options as $key=>$value) {
	$return .= '<option value="'.$key.'" '.checkSelected($key).'>'.$value.'</option>';	
}

?>

<select id="select1" name="select1" class="dropper" value="<?=$select1;?>"> 
<?php 
	// We could just loop here but I prefer to output the $return variable
	echo($return); 
?>
</select>

In order to add more options, you just need to add more values to the $options array.

I removed the name & id on each option as I couldn't see the point in them being there.

In order for the above code to work, you need to capture the value from the select1 on your error page then pass it back via GET or POST as 'choice', the script will take care of the rest.

I hope this helps, if not, let me know the issues.

Horus_Kol · 10-14-2009, 09:51 PM

only one thing with your code Uze - <select> elements don't take a value attribute... other than that - pretty close to what I'd do...

Vege · 10-15-2009, 03:37 AM

Quote:

Horus_Kol disagrees: stating the obvious doesn't help things

But AFAIK when it's the only thing to do to to ensure crossbrowser combability i think it's in place to mention.
After page refresh you need to change the selected="selected" by yourself as some browsers will remember the selected value and some will not.

He was obviously missing this.

Horus_Kol · 10-15-2009, 07:12 PM

Quote:

Originally Posted by Vege

But AFAIK when it's the only thing to do to to ensure crossbrowser combability i think it's in place to mention.
After page refresh you need to change the selected="selected" by yourself as some browsers will remember the selected value and some will not.

He was obviously missing this.

maybe - but without showing a PHP code snippet for how to determine which of the options should be selected, your statement is next to useless...

Vege · 10-16-2009, 12:16 PM

Quote:

Originally Posted by Horus_Kol

maybe - but without showing a PHP code snippet for how to determine which of the options should be selected, your statement is next to useless...

So exact statement what needs to be done is useless and only amount of lines i wrote or code i produce matters?

Horus_Kol · 10-17-2009, 12:38 AM

Quote:

Originally Posted by Vege

So exact statement what needs to be done is useless and only amount of lines i wrote or code i produce matters?

no - but when that exact statement isn't supported by any suggestions on how to do the thing that you say should be done, then that is useless.

now, please, drop this off-topic conversation...

Pegasus · 10-17-2009, 01:00 AM

Okay, gentlemen, back in your corners so you can help out an old woman trying to learn PHP and other such mind-benders at 11 at night.

Let me see if I understand the code correctly. Option can have a value, but select can't. Would it not work out with this code:

<select id="select1" name="select1" class="dropper" value="<?=$select1;?>">

To have the value replaced with selected?

<select id="select1" name="select1" class="dropper" selected="<?=$select1;?>">

Vege · 10-17-2009, 06:34 AM

PHP Code:


			
select id="select1" name="select1" class="dropper" >

<option <?php echo ($select1=="none") ?" selected=\"selected\" ":""; ?>  value="none">None</option>

<option <?php echo ($select1=="option1") ?" selected=\"selected\" ":""; ?> value="option1">Option1</option>

<option <?php echo ($select1=="option2") ?" selected=\"selected\" ":""; ?>  value="option2">Option2</option>

<option <?php echo ($select1=="optio3") ?" selected=\"selected\" ":""; ?>  value="option3">Option3</option>

</select>

Select don't have a value or selected property. Those are option propertys.
Name property belogns to select, not option.
And as peg stated no same ID:s

This should make it work, im done with this thread.

Pegasus · 10-17-2009, 06:44 AM

**Now** it makes sense. $select1 has to be in the options in order to be selected, not in the select part of the code. Thanks!