PDA

View Full Version : problems with a banner rotation script

karinne
06-03-2005, 10:37 AM
man... haven't been here in a while... nice :)

i've got a problem with a banner rotation script i took from another site of mine. here's the problem site

http://www.arso.qc.ca/2/

where it says "COMMANDITAIRES", the images aren't showing up at all. I made sure that they're all the same size.

in ff i opened the javascript console and the error that shows up is

"document.sponsor has no properties" on line 56

any help would be greatly appreciated!

tia
¥åßßå
06-03-2005, 10:58 AM
You're missing the image it needs,
<div id="commanditaires">
<div class="otherheading"><h1>Commanditaires</h1></div>
<script language="javascript">
<!-- Hide JavaScript from Java-Imp aired Browsers
sctr=0;
rotateIt();
// End Hiding -->
</script>
<img id="sponsor" width="##px" height="##px" alt="Our sponsor" src="default_banner.jpg" />
</div>

¥
coothead
06-03-2005, 11:59 AM
Hi there karinne,

¥åßßå has correctly stated the cause of your problem, but it will still not work in that position.
Also a slight modification to banner-rotation.js will be required, as you are using a strict DOCTYPE.

The image needs to be positioned like this..
<div id="commanditaires">
<div class="otherheading"><h1>Commanditaires</h1></div>
<img id="sponsor" src="" alt=""/>
<script type="text/javascript">
<!-- Hide JavaScript from Java-Impaired Browsers
sctr=0;
rotateIt();
// End Hiding -->
</script>
</div>
...and then change this line...
document.sponsor.src=isn[sctr].src;
...to this...
document.getElementById("sponsor").src=isn[sctr].src;
...in the script.

I also popped your page through the validator and made the necessary corrections. :D
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
"http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>ARSO - Association R&eacute;gionale de Soccer de l'Outaouais</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<link rel="stylesheet" href="/2/css/master.css" media="screen" type="text/css" />
<script type="text/javascript" src="/js/drop-down.js"></script>
<script type="text/javascript" src="/js/banner-rotation.js"></script>
</head>
<body>
<div id="wrap">
<div id="header">
<map name="map" id="map">
<area shape="rect" coords="20,5,215,95" href="/2/" alt=""/>
</map>
<img src="/2/i/banner.jpg" width="760" height="100" style="border: 0;" usemap="#map" alt="ARSO" />
</div>
<div id="topnav">
<ul id="nav">
<li><a href="/l-arso/contact.php">ARSO</a>
<ul>
<li><a href="/arso/notre-mission.php">Notre mission</a></li>
<li><a href="/l-arso/conseil-d-administration.php">Conseil d'administration</a></li>
<li><a href="/arso/contactez-larso.php">Contactez l'ARSO</a></li>
</ul>
</li>
<li><a href="">Clubs</a>
<ul>
<li><a href="/clubs/?clubid=2">Association de Soccer de Buckingham</a></li>
<li><a href="/clubs/?clubid=3">Association de Soccer de Gatineau</a></li>
<li><a href="/clubs/?clubid=4">Association de Soccer de Hull</a></li>
<li><a href="/clubs/?clubid=5">Association de Soccer de Masson-Angers</a></li>
<li><a href="/clubs/?clubid=6">Club de Soccer d'Aylmer</a></li>
<li><a href="/clubs/?clubid=7">Club de Soccer de Cantley</a></li>
<li><a href="/clubs/?clubid=8">Club de Soccer Chapeau/Upper Pontiac</a></li>
<li><a href="/clubs/?clubid=9">Club de Soccer de Chelsea</a></li>
<li><a href="/clubs/?clubid=10">Club de Soccer de la Petite-Nation</a></li>
<li><a href="/clubs/?clubid=11">Club de Soccer de Thurso</a></li>
<li><a href="/clubs/?clubid=12"> FC Outaouais</a></li>
<li><a href="/clubs/?clubid=13">Soccer Haute-Gatineau</a></li>
<li><a href="/clubs/?clubid=14">Soccer Papineauville</a></li>
</ul>
</li>
<li><a href="">Documents</a>
<ul>
<li><a href="/documents-important/assurances/">Assurances</a></li>
<li><a href="/documents-important/permis-de-voyage/">Permis de voyage</a></li>
</ul>
</li>
<li><a href="/droit-au-but/index-new.php">Droit au but</a></li>
<li><a href="">Calendrier</a></li>
<li><a href="">Liens</a></li>
</ul>
</div>
<div id="core">
<div id="leftmenu">
<div class="menuheading"><h1>Navigation</h1></div>
<div id="menu">
<ul id="submenu">
<li><a href="">Arbitrage</a></li>
<li><a href="/centre-regional-de-developpement/">Centre R&eacute;gional de D&eacute;veloppement</a></li>
<li><a href="">Technique</a></li>
<li><a href="">Sport-&eacute;tudes</a></li>
<li><a href="/coupe-de-l-outaouais/index-new.php">Coupe de l'Outaouais</a></li>
<li><a href="">LRSO</a></li>
<li><a href="">Terrains de la r&eacute;gion</a></li>
<li><a href="">Soccer Senior</a></li>
<li><a href="">CISO Juv&eacute;nile</a></li>
<li><a href="">Championnat d'hivers senior</a></li>
<li><a href="">Campagne de sensibilisation</a></li>
<li><a href="">Gala M&eacute;ritas</a></li>
<li><a href="">Album-photos</a></li>
<li><a href="">Revues de presse</a></li>
</ul>
</div>
</div>
<div id="content">
<div id="mainstory">
<div class="mainheading"><h1>Nouvelle du jour</h1></div>
<div style="text-align: center; padding-top: 2px;"><img src="/i/nouvelles/thumbnails-200/logo-LRSO-2.JPG" style="border: 1px solid #000;" alt=""/></div>
<div class="date">20 mai, 2005</div>
<div class="newstitle">Rencontre pour entraîneurs LRSO</div>
<p>Le mercredi 25 mai de 19h00 à 21h00, au centre communautaire St-Jean-Brébeuf, rue St-Louis, secteur Gatineau
<br />Et
<br />Le jeudi 26 mai de 19h00 à 21h00, à l'École secondaire de l'Île, rue St-Rédempteur, scteur ... <strong>[<a href="/nouvelles/?nid=26">suite</a>]</strong>
</p>
</div>
<div id="other">
<div class="impheading"><h1>Important</h1></div>
<div style="text-align: center;"><img src="/coupe-de-l-outaouais/logo.gif" style="border: 1px solid #000;" alt="Coupe de l'Outaouais McDonald's 2005" /></div>
<div class="newsheading"><h1>Nouvelles en bref</h1></div>
<ul>
<li><a href="/nouvelles/?nid=25">L'Impact de Montréal termine son camp d'entraînement</a> (2005-04-29)</li>
<li><a href="/nouvelles/?nid=24">Équipe Canadienne Féminine</a> (2005-04-29)</li>
<li><a href="/nouvelles/?nid=23">Équipe Canadienne U17 M</a> (2005-04-29)</li>

<li><a href="/nouvelles/?nid=22">Formations PNCE 2005</a> (2005-04-29)</li>
<li><a href="/nouvelles/?nid=21">L'impact - Avril 2005</a> (2005-04-15)</li>
</ul>
</div>
</div>
<br style="clear:both" />
</div>
<div id="secondrow">
<div id="desclubs">
<div class="otherheading"><h1>Nouvelles des clubs</h1></div>
<ul>
<li><a href="/nouvelles/?nid=27">Chelsea cherche des joueurs</a> (2005-05-20)</li>
<li><a href="/nouvelles/?nid=19">ASH - Camps de jour et stages avancés été 2005</a> (2005-04-08)</li>
<li><a href="/nouvelles/?nid=7">Inscription dans les clubs - Été 2005</a> (2005-01-29)</li>
</ul>
</div>
<div id="desequipes">
<div class="otherheading"><h1>Nouvelles des &eacute;quipes</h1></div>
<ul>
<li><a href="/nouvelles/?nid=14">Équipe U10 de l'ASH à Catalogna</a> (2005-04-08)</li>
</ul>
</div>
<div id="commanditaires">
<div class="otherheading"><h1>Commanditaires</h1></div>
<img id="sponsor" src="" alt=""/>
<script type="text/javascript">
<!-- Hide JavaScript from Java-Impaired Browsers
sctr=0;
rotateIt();
// End Hiding -->
</script>
</div>
<div id="sondage"><div class="otherheading"><h1>Sondage</h1></div></div>
</div>
<br style="clear:both" />
</div>
</body>
</html>
karinne
06-03-2005, 12:16 PM
Perfect! Thanks Coot!

I'm not done the site yet so I haven't checked on through the validator yet ;)
coothead
06-03-2005, 12:27 PM
No problem karinne, you're welcome. :D